Ruby on Rails Michael Hartl第8.5章测试失败

我已经看到了另一个问题，其中current_user变量被定义了两次。 我的代码中有相同的错误，但删除current_user的第二个定义仍然无法解决我收到的错误消息。 这是我在运行测试时得到的错误消息：

---

1) Failure: SessionsHelperTest#test_current_user_returns_right_user_when_session_is_nil [/home/ubuntu/workspace/sample_app/test/helpers/sessions_helper_test.rb:11]: --- expected +++ actual @@ -1 +1 @@ -# +nil 

---

这是我的sessions_helper文件：

---

 module SessionsHelper #logs in the given user def log_in(user) session[:user_id] = user.id end #remembers a user in a persistent session def remember(user) user.remember cookies.permanent.signed[:user_id] = user.id cookies.permanent[:remember_token] = user.remember_token end #returns current logged in user #def current_user #@current_user ||= User.find_by(id: session[:user_id]) #end #returns the user corresponding to the remember token def current_user if (user_id = session[:user_id]) @current_user ||= User.find_by(id: user_id) elsif (user_id = cookies.signed[:user_id]) user = User.find_by(id: user_id) if user && user.authenticated?(cookies[:remember_token]) log_in user @current_user = user end end end def logged_in? !current_user.nil? end def log_out session.delete(:user_id) @current_user = nil end #forgets a persistent session def forget(user) user.forget cookies.delete(:user_id) cookies.delete(:remember_token) end #logs out the current user def log_out forget(current_user) session.delete(:user_id) @current_user = nil end end 

---

这是我的users_login_test文件：

---

 require 'test_helper' class UsersLoginTest < ActionDispatch::IntegrationTest def setup @user = users(:michael) end test "Login with invalid information followed by logout" do get login_path post login_path, session: { email: @user.email, password: 'password' } assert is_logged_in? assert_redirected_to @user follow_redirect! assert_template 'users/show' assert_select "a[href=?]", login_path, count: 0 assert_select "a[href=?]", logout_path assert_select "a[href=?]", user_path(@user) delete logout_path assert_not is_logged_in? assert_redirected_to root_url #simulate a user logging out in a different window delete logout_path follow_redirect! assert_select "a[href=?]", login_path assert_select "a[href=?]", logout_path, count: 0 assert_select "a[href=?]", user_path(@user), count: 0 end test "login with remembering" do log_in_as(@user, remember_me: '1') assert_not_nil cookies['remember_token'] end test "login without remembering" do log_in_as(@user, remember_me: '0') assert_nil cookies['remember_token'] end end 

---

这是我的test_helper文件：

---

 ENV['RAILS_ENV'] ||= 'test' require File.expand_path('../../config/environment', __FILE__) require 'rails/test_help' class ActiveSupport::TestCase fixtures :all # Returns true if a test user is logged in. def is_logged_in? !session[:user_id].nil? end # Logs in a test user. def log_in_as(user, options = {}) password = options[:password] || 'password' remember_me = options[:remember_me] || '1' if integration_test? post login_path, session: { email: user.email, password: password, remember_me: remember_me } else session[:user_id] = user.id end end private # Returns true inside an integration test. def integration_test? defined?(post_via_redirect) end end 

---

这是我的users.yml文件：

---

 michael: name: Michael Example email: [e-mail] password_digest:  

---

我真的不确定什么是错的，但我想我只是错过了一些东西。 任何帮助将非常感激！ 谢谢！

---

编辑：这是我的user.rb文件：

---

 class User < ActiveRecord::Base attr_accessor :remember_token before_save { self.email = email.downcase } validates :name, presence: true, length: { maximum: 50 } VALID_EMAIL_REGEX = /\A[\w+\-.]+@[az\d\-.]+\.[az]+\z/i validates :email, presence: true, length: { maximum: 255 }, format: { with: VALID_EMAIL_REGEX }, niqueness: { case_sensitive: false } has_secure_password validates :password, presence: true, length: { minimum: 6 } #returns the digest of a given string def User.digest(string) cost = ActiveModel::SecurePassword.min_cost ? BCrypt::Engine::MIN_COST : BCrypt::Engine.cost BCrypt::Password.create(string, cost: cost) end #returns random token def User.new_token SecureRandom.urlsafe_base64 end #remembers a user in the database for persistent sessions def remember self.remember_token = User.new_token update_attribute(:remember_token, User.digest(remember_token)) end #returms true if the given token matches the digest def authenticated?(remember_token) return false if remember_digest.nil? BCrypt::Password.new(remember_digest).is_password? (remember_token) end #Forgets a user def forget update_attribute(:remember_digest, nil) end end 

---

编辑：sessions_helper_test.rb：

---

 require 'test_helper' class SessionsHelperTest < ActionView::TestCase def setup @user = users(:michael) remember(@user) end test "current_user returns right user when session is nil" do assert_equal @user, current_user assert is_logged_in? end test "current_user returns nil when remember digest is wrong" do @user.update_attribute(:remember_digest, User.digest(User.new_token)) assert_nil current_user end end 

Answer 1

查看您的sessions_helper.rb， # Logs out the current user已在文件中定义了两次# Logs out the current user方法。 根据第8章中的本教程，为了运行测试套件绿色，您需要在文件中包含以下内容。

我认为你在清单8.39中搞砸了这一点，你只需要在log_out方法中添加一行。

请填写sessions_helper.rb中的以下代码，您的测试将变为绿色。

 module SessionsHelper # Logs in the given user. def log_in(user) session[:user_id] = user.id end # Remembers a user in a persistent session. def remember(user) user.remember cookies.permanent.signed[:user_id] = user.id cookies.permanent[:remember_token] = user.remember_token end # Returns the user corresponding to the remember token cookie. def current_user if (user_id = session[:user_id]) @current_user ||= User.find_by(id: user_id) elsif (user_id = cookies.signed[:user_id]) user = User.find_by(id: user_id) if user && user.authenticated?(cookies[:remember_token]) log_in user @current_user = user end end end # Returns true if the user is logged in, false otherwise. def logged_in? !current_user.nil? end # Forgets a persistent session. def forget(user) user.forget cookies.delete(:user_id) cookies.delete(:remember_token) end # Logs out the current user. def log_out forget(current_user) session.delete(:user_id) @current_user = nil end end 

更新：同样在app / models / user.rb文件中根据清单8.45，你需要添加一行return false if remember_digest.nil? 。 所以user.rb文件应如下所示。

 class User < ActiveRecord::Base attr_accessor :remember_token before_save { self.email = email.downcase } validates :name, presence: true, length: { maximum: 50 } VALID_EMAIL_REGEX = /\A[\w+\-.]+@[az\d\-.]+\.[az]+\z/i validates :email, presence: true, length: { maximum: 255 }, format: { with: VALID_EMAIL_REGEX }, uniqueness: { case_sensitive: false } has_secure_password validates :password, presence: true, length: { minimum: 6 } # Returns the hash digest of the given string. def User.digest(string) cost = ActiveModel::SecurePassword.min_cost ? BCrypt::Engine::MIN_COST : BCrypt::Engine.cost BCrypt::Password.create(string, cost: cost) end # Returns a random token. def User.new_token SecureRandom.urlsafe_base64 end # Remembers a user in the database for use in persistent sessions. def remember self.remember_token = User.new_token update_attribute(:remember_digest, User.digest(remember_token)) end # Returns true if the given token matches the digest. def authenticated?(remember_token) return false if remember_digest.nil? #Add this line BCrypt::Password.new(remember_digest).is_password?(remember_token) end # Forgets a user. def forget update_attribute(:remember_digest, nil) end end 

如果您再遇到任何错误，请与我们联系。